Skip to content

Remove application kind from pipedv1 logic#6008

Merged
khanhtc1202 merged 5 commits into
masterfrom
remove-application-kind-pipedv1
Jul 10, 2025
Merged

Remove application kind from pipedv1 logic#6008
khanhtc1202 merged 5 commits into
masterfrom
remove-application-kind-pipedv1

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

What this PR does:

  • Remove application Kind value from app config reporter logic (pipedv1)
  • Remove application Kind value from Slack notifier logic (pipedv1) - using application Labels instead
  • Add TODO note to remove application Kind value from LiveStateReporter logic (pipedv1) - currently the UI is using that value to render the correct StateView component (ref: Make PipeCD control plane support plugin-arched piped #5252 (comment))

Why we need it:

The pipedv1 logic should not depend on the application Kind value.

Which issue(s) this PR fixes:

Part of #5252

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.22%. Comparing base (038a2c6) to head (0bbd96a).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/notifier/slack.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6008      +/-   ##
==========================================
+ Coverage   28.19%   28.22%   +0.02%     
==========================================
  Files         520      520              
  Lines       56011    56012       +1     
==========================================
+ Hits        15790    15807      +17     
+ Misses      38970    38958      -12     
+ Partials     1251     1247       -4     
Flag Coverage Δ
. 23.26% <88.88%> (+0.03%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes 66.27% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 80.26% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.71% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit d66dda4 into master Jul 10, 2025
40 checks passed
@khanhtc1202 khanhtc1202 deleted the remove-application-kind-pipedv1 branch July 10, 2025 07:06
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants