Skip to content

Implement the traffic routing stage with skeleton code#6015

Merged
t-kikuc merged 1 commit into
masterfrom
k8s-plugin-traffic-routing-impl-1
Jul 10, 2025
Merged

Implement the traffic routing stage with skeleton code#6015
t-kikuc merged 1 commit into
masterfrom
k8s-plugin-traffic-routing-impl-1

Conversation

@Warashi
Copy link
Copy Markdown
Member

@Warashi Warashi commented Jul 9, 2025

What this PR does:

This PR adds executeK8sTrafficRoutingStage implementation with switch-case for traffic routing methods.

Why we need it:

to support traffic routing in k8s plugin

Which issue(s) this PR fixes:

Part of #5764

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi Warashi requested a review from a team as a code owner July 9, 2025 06:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 28.19%. Comparing base (69ce763) to head (fef2bb1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...pp/pipedv1/plugin/kubernetes/deployment/traffic.go 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6015      +/-   ##
==========================================
- Coverage   28.21%   28.19%   -0.03%     
==========================================
  Files         520      520              
  Lines       56046    56068      +22     
==========================================
- Hits        15814    15808       -6     
- Misses      38980    39008      +28     
  Partials     1252     1252              
Flag Coverage Δ
. 23.21% <ø> (-0.02%) ⬇️
.-pkg-app-pipedv1-plugin-kubernetes 65.94% <0.00%> (-0.50%) ⬇️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 80.26% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.71% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-kikuc t-kikuc enabled auto-merge (squash) July 10, 2025 01:28
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit 4b58150 into master Jul 10, 2025
38 of 40 checks passed
@t-kikuc t-kikuc deleted the k8s-plugin-traffic-routing-impl-1 branch July 10, 2025 06:57
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants