Skip to content

Delete unused flag 'Retries' from Terraform config#6022

Merged
t-kikuc merged 2 commits into
masterfrom
fix-tf-retries-unused
Jul 14, 2025
Merged

Delete unused flag 'Retries' from Terraform config#6022
t-kikuc merged 2 commits into
masterfrom
fix-tf-retries-unused

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Jul 14, 2025

What this PR does:

  • Delete 'Retries' from TerraformSyncStageOptions and TerraformApplyStageOptions
  • Delete 'Retries' from all docs

Why we need it:

'Retries' has never been used.
It's a trap for users.

cf.
v0.42.0 does not use 'Retries'
https://github.com/pipe-cd/pipecd/blob/v0.42.0/pkg/config/application_terraform.go#L58-L74

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

t-kikuc added 2 commits July 14, 2025 10:53
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc requested a review from a team as a code owner July 14, 2025 01:57
@t-kikuc t-kikuc enabled auto-merge (squash) July 14, 2025 01:57
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@t-kikuc t-kikuc marked this pull request as draft July 14, 2025 01:58
auto-merge was automatically disabled July 14, 2025 01:58

Pull request was converted to draft

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.28%. Comparing base (0c99936) to head (554e9e3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6022      +/-   ##
==========================================
- Coverage   28.28%   28.28%   -0.01%     
==========================================
  Files         523      523              
  Lines       56135    56135              
==========================================
- Hits        15879    15875       -4     
- Misses      39005    39008       +3     
- Partials     1251     1252       +1     
Flag Coverage Δ
. 23.27% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 65.94% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 66.66% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 80.26% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.50% <ø> (-0.21%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-kikuc
Copy link
Copy Markdown
Member Author

t-kikuc commented Jul 14, 2025

Let me rerun the lint/go.

🐶 Installing reviewdog ... https://github.com/reviewdog/reviewdog
Error: Error: socket hang up

@t-kikuc t-kikuc marked this pull request as ready for review July 14, 2025 02:00
@t-kikuc t-kikuc enabled auto-merge (squash) July 14, 2025 02:01
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit 2f29597 into master Jul 14, 2025
54 of 56 checks passed
@t-kikuc t-kikuc deleted the fix-tf-retries-unused branch July 14, 2025 02:09
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants