Skip to content

chore(docs): migrate deprecated Hugo syntax for v0.148.2(latest) support#6099

Merged
khanhtc1202 merged 5 commits into
pipe-cd:masterfrom
niladrix719:hugo-templates
Aug 19, 2025
Merged

chore(docs): migrate deprecated Hugo syntax for v0.148.2(latest) support#6099
khanhtc1202 merged 5 commits into
pipe-cd:masterfrom
niladrix719:hugo-templates

Conversation

@niladrix719
Copy link
Copy Markdown
Member

@niladrix719 niladrix719 commented Aug 1, 2025

What this PR does:

migrate deprecated Hugo syntax for v0.148.2(latest) support

Why we need it:

Hugo v0.148.2 introduces breaking changes in templating syntax, so the templates were updated to ensure the docs site builds without errors


[Added] Fixes #4902

Signed-off-by: “niladrix719” <niladrix719@gmail.com>
@niladrix719 niladrix719 requested a review from a team as a code owner August 1, 2025 16:58
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
khanhtc1202
khanhtc1202 previously approved these changes Aug 3, 2025
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you 👌

Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niladrix719
[ask] We use 0.128.0 for now. Is the new syntax available for 0.128.0 too?

with:
hugo-version: '0.128.0'
extended: true

@niladrix719
Copy link
Copy Markdown
Member Author

@niladrix719 [ask] We use 0.128.0 for now. Is the new syntax available for 0.128.0 too?

I tested the site locally with Hugo v0.128.0, and the updated syntax works fine. We could consider updating the version in the workflow as well — wdyt?

niladrix719 and others added 2 commits August 6, 2025 15:38
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.52%. Comparing base (12361db) to head (ce26f75).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6099       +/-   ##
===========================================
+ Coverage   28.47%   38.52%   +10.05%     
===========================================
  Files         536       35      -501     
  Lines       57137     3509    -53628     
===========================================
- Hits        16267     1352    -14915     
+ Misses      39602     2088    -37514     
+ Partials     1268       69     -1199     
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes ?
.-pkg-app-pipedv1-plugin-kubernetes_multicluster ?
.-pkg-app-pipedv1-plugin-scriptrun ?
.-pkg-app-pipedv1-plugin-terraform ?
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval ?
.-pkg-plugin-sdk 51.40% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go to 148

@t-kikuc
Copy link
Copy Markdown
Member

t-kikuc commented Aug 15, 2025

Let's merge this after releasing v0.53.0 next week.

@t-kikuc
Copy link
Copy Markdown
Member

t-kikuc commented Aug 15, 2025

This PR fixes #4902

@khanhtc1202 khanhtc1202 merged commit 2970387 into pipe-cd:master Aug 19, 2025
60 of 61 checks passed
@niladrix719
Copy link
Copy Markdown
Member Author

niladrix719 commented Aug 19, 2025

Sorry, I think the site publish CI is failing after this PR (since the docs-v0.53.x changes were missed). Hopefully, this fixes it: #6140

cc @khanhtc1202 @t-kikuc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Hugo version for the site

3 participants