Skip to content

[WaitApproval Plugin] implement executeStage for the waitapproval plugin#6109

Merged
t-kikuc merged 8 commits into
pipe-cd:masterfrom
niladrix719:waitapproval-executeStage#6067
Aug 28, 2025
Merged

[WaitApproval Plugin] implement executeStage for the waitapproval plugin#6109
t-kikuc merged 8 commits into
pipe-cd:masterfrom
niladrix719:waitapproval-executeStage#6067

Conversation

@niladrix719
Copy link
Copy Markdown
Member

@niladrix719 niladrix719 commented Aug 7, 2025 •
edited
Loading

What this PR does:

Implements the executeWaitApproval function

Screenshot 2025-08-08 at 12 53 28 AM

Why we need it:

To execute the waitapproval plugin

Which issue(s) this PR fixes:

Fixes #6067

@niladrix719
feat(plugin): implement executeStage for the waitapproval plugin
9b0d47c 
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
@niladrix719 niladrix719 requested a review from a team as a code owner August 7, 2025 19:22
@niladrix719
fix: lint
4030ba4 
Signed-off-by: “niladrix719” <niladrix719@gmail.com>
@niladrix719 niladrix719 marked this pull request as draft August 7, 2025 19:52
@niladrix719 niladrix719 marked this pull request as ready for review August 16, 2025 18:35
@t-kikuc t-kikuc changed the title feat(plugin): implement executeStage for the waitapproval plugin [WaitApproval Plugin] implement executeStage for the waitapproval plugin Aug 20, 2025
t-kikuc
t-kikuc requested changes Aug 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Comment thread pkg/app/pipedv1/plugin/waitapproval/waitapproval.go
Comment thread pkg/app/pipedv1/plugin/waitapproval/waitapproval.go Outdated
Comment thread pkg/app/pipedv1/plugin/waitapproval/waitapproval.go Outdated
Comment thread pkg/app/pipedv1/plugin/waitapproval/waitapproval.go Outdated
Comment thread pkg/app/pipedv1/plugin/waitapproval/waitapproval.go Outdated
Comment thread pkg/app/pipedv1/plugin/waitapproval/waitapproval.go
Comment thread pkg/app/pipedv1/plugin/waitapproval/waitapproval.go Outdated
Comment thread pkg/app/pipedv1/plugin/waitapproval/waitapproval.go Outdated
Comment thread pkg/app/pipedv1/plugin/waitapproval/waitapproval.go
Comment thread pkg/app/pipedv1/plugin/waitapproval/waitapproval.go Outdated
niladrix719 and others added 2 commits August 22, 2025 15:37
@niladrix719 niladrix719 requested a review from t-kikuc August 22, 2025 10:20
t-kikuc
t-kikuc approved these changes Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@t-kikuc t-kikuc enabled auto-merge (squash) August 25, 2025 13:27
Warashi
Warashi approved these changes Aug 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@t-kikuc t-kikuc merged commit bc48830 into pipe-cd:master Aug 28, 2025
61 of 62 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Warashi Warashi Warashi approved these changes

@t-kikuc t-kikuc t-kikuc approved these changes

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202 khanhtc1202 is a code owner automatically assigned from pipe-cd/pipecd-approvers

Assignees

No one assigned

Labels

area/go area/pipedv1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement WaitApproval Stage Plugin

3 participants

@niladrix719 @Warashi @t-kikuc