Skip to content

Cloudrun stage base#6115

Merged
t-kikuc merged 5 commits into
pipe-cd:masterfrom
hiep-tk:cloudrun
Aug 18, 2025
Merged

Cloudrun stage base#6115
t-kikuc merged 5 commits into
pipe-cd:masterfrom
hiep-tk:cloudrun

Conversation

@hiep-tk
Copy link
Copy Markdown
Contributor

@hiep-tk hiep-tk commented Aug 13, 2025 •
edited by khanhtc1202
Loading

What this PR does: buildStage and struct for CloudRun

Why we need it: to build cloudrun plugin

Which issue(s) this PR fixes:

Part of #6114

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

hiep-tk added 3 commits August 13, 2025 17:02
@hiep-tk
boilerplate and struct migration for cloudrun
fc62463 
Signed-off-by: hiep-tk <hiep.trinhkhanh0466@gmail.com>
@hiep-tk
pipeline and quicksync stages build
11e556e 
Signed-off-by: hiep-tk <hiep.trinhkhanh0466@gmail.com>
@hiep-tk
lint
c376959 
Signed-off-by: hiep-tk <hiep.trinhkhanh0466@gmail.com>
@hiep-tk hiep-tk requested a review from a team as a code owner August 13, 2025 09:31
@hiep-tk
fix lint
0858749 
Signed-off-by: hiep-tk <hiep.trinhkhanh0466@gmail.com>
khanhtc1202
khanhtc1202 previously approved these changes Aug 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go, thanks 👌

t-kikuc
t-kikuc reviewed Aug 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think the path should be pkg/app/pipedv1/plugin/cloudrunservice/xxxxx (cloudrun->cloudrunservice) since we have a plan to support Cloud Run Jobs.

@khanhtc1202 WDYT?

@hiep-tk
update package name
8896d5c 
Signed-off-by: hiep-tk <hiep.trinhkhanh0466@gmail.com>
@t-kikuc t-kikuc enabled auto-merge (squash) August 15, 2025 01:34
@hiep-tk hiep-tk requested a review from khanhtc1202 August 15, 2025 07:56
@khanhtc1202
Copy link
Copy Markdown
Member

khanhtc1202 commented Aug 18, 2025

@t-kikuc, if those 2 plugins are independent, I think they should be the same as the k8s and k8s-multicluster plugin; thus, there is no need to have a parent directory. Wdyt?

khanhtc1202
khanhtc1202 approved these changes Aug 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@t-kikuc t-kikuc merged commit c4b45cd into pipe-cd:master Aug 18, 2025
45 checks passed
@linhdangduy linhdangduy mentioned this pull request Aug 19, 2025
Closed
@t-kikuc
Copy link
Copy Markdown
Member

t-kikuc commented Aug 20, 2025

@khanhtc1202

OMG, I mistakenly approved.

As I pointed out, we should have like this:

plugins/
|--k8s/
|--cloudrunservice/
|--cloudrunjobs/

@hiep-tk
please fix in another PR later.

@github-actions github-actions Bot mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

@t-kikuc t-kikuc t-kikuc approved these changes

@Warashi Warashi Awaiting requested review from Warashi Warashi is a code owner automatically assigned from pipe-cd/pipecd-approvers

Assignees

No one assigned

Labels

area/go area/pipedv1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiep-tk @khanhtc1202 @t-kikuc