Skip to content

CI: Deny dependency from plugins to pipe-cd/pipecd#6145

Merged
t-kikuc merged 1 commit into
masterfrom
depguard-plugin
Aug 25, 2025
Merged

CI: Deny dependency from plugins to pipe-cd/pipecd#6145
t-kikuc merged 1 commit into
masterfrom
depguard-plugin

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Aug 21, 2025

What this PR does:

Deny deps from files under pipedv1/plugin/** to outside them.

Examples:

  • Allow:
    • github.com/pipe-cd/piped-plugin-sdk-go
    • github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/terraform/config
      • k8s -> tf is not denied in this rule, but not allowed
  • Deny:
    • github.com/pipe-cd/pipecd/pkg/config
    • github.com/pipe-cd/pipecd/pkg/model

Why we need it:

This PR makes it easier to review and develop.
The plugins cannot depend on pipe-cd/pipecd except the SDK and its local modules for simplicity.

Which issue(s) this PR fixes:

Related to #5259

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc requested a review from a team as a code owner August 21, 2025 08:26
@t-kikuc t-kikuc enabled auto-merge (squash) August 21, 2025 08:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.67%. Comparing base (64742f7) to head (8ecfa72).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6145      +/-   ##
==========================================
+ Coverage   27.88%   28.67%   +0.79%     
==========================================
  Files         517      535      +18     
  Lines       55356    57333    +1977     
==========================================
+ Hits        15434    16442    +1008     
- Misses      38685    39613     +928     
- Partials     1237     1278      +41     
Flag Coverage Δ
. 23.27% <ø> (ø)
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 62.30% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.98% <ø> (?)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🙆‍♂️

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@t-kikuc t-kikuc merged commit dcb3006 into master Aug 25, 2025
48 checks passed
@t-kikuc t-kikuc deleted the depguard-plugin branch August 25, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants