CI: Deny dependency from plugins to pipe-cd/pipecd#6145
Merged
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6145 +/- ##
==========================================
+ Coverage 27.88% 28.67% +0.79%
==========================================
Files 517 535 +18
Lines 55356 57333 +1977
==========================================
+ Hits 15434 16442 +1008
- Misses 38685 39613 +928
- Partials 1237 1278 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Deny deps from files under
pipedv1/plugin/**to outside them.Examples:
Why we need it:
This PR makes it easier to review and develop.
The plugins cannot depend on pipe-cd/pipecd except the SDK and its local modules for simplicity.
Which issue(s) this PR fixes:
Related to #5259
Does this PR introduce a user-facing change?: