Skip to content

[Terraform Plugin] Implemented PlanPreview#6150

Merged
t-kikuc merged 4 commits into
masterfrom
plugin/terraform/planpreview/work
Sep 1, 2025
Merged

[Terraform Plugin] Implemented PlanPreview#6150
t-kikuc merged 4 commits into
masterfrom
plugin/terraform/planpreview/work

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Aug 22, 2025

What this PR does:

as title

cf. I referred to terraformdiff.go in pipedv0:
https://github.com/pipe-cd/pipecd/blob/449844d3b45846974af7d54c34017c2166467e92/pkg/app/piped/planpreview/terraformdiff.go

Why we need it:

to support Terraform PlanPreview in pipedv1 too

Which issue(s) this PR fixes:

Fixes #5992

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 55.81395% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.68%. Comparing base (8810ce2) to head (5332e60).
⚠️ Report is 44 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/terraform/planpreview/plugin.go 57.14% 18 Missing ⚠️
pkg/app/pipedv1/plugin/terraform/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6150   +/-   ##
=======================================
  Coverage   28.67%   28.68%           
=======================================
  Files         535      536    +1     
  Lines       57333    57376   +43     
=======================================
+ Hits        16442    16460   +18     
- Misses      39613    39638   +25     
  Partials     1278     1278           
Flag Coverage Δ
. 23.26% <ø> (-0.02%) ⬇️
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 62.30% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 39.49% <55.81%> (+1.17%) ⬆️
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.98% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@t-kikuc t-kikuc merged commit 802e10c into master Sep 1, 2025
48 checks passed
@t-kikuc t-kikuc deleted the plugin/terraform/planpreview/work branch September 1, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Terraform plugin

3 participants