Skip to content

[Analysis Plugin] Add StageStatusSkipped to the SDK#6156

Merged
t-kikuc merged 1 commit into
masterfrom
plugin/analysis/sdk-skip
Aug 26, 2025
Merged

[Analysis Plugin] Add StageStatusSkipped to the SDK#6156
t-kikuc merged 1 commit into
masterfrom
plugin/analysis/sdk-skip

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Aug 25, 2025

What this PR does:

as title

Why we need it:

to handle manual skipping in the Analysis Plugin

cf. pipedv0:

case <-ticker.C:
if !e.checkSkippedByCmd(ctx) {
continue
}
status = model.StageStatus_STAGE_SKIPPED
// Stop the context to cancel all running analyses.
cancel()
return
case <-doneCh:

Which issue(s) this PR fixes:

Part of #6068

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc requested a review from a team as a code owner August 25, 2025 10:25
@t-kikuc t-kikuc enabled auto-merge (squash) August 25, 2025 10:25
@github-actions github-actions Bot added area/go area/plugin-sdk piped-plugin-sdk labels Aug 25, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.68%. Comparing base (45a82f7) to head (934cab5).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6156   +/-   ##
=======================================
  Coverage   28.68%   28.68%           
=======================================
  Files         534      534           
  Lines       57328    57330    +2     
=======================================
+ Hits        16442    16444    +2     
  Misses      39608    39608           
  Partials     1278     1278           
Flag Coverage Δ
. 23.28% <ø> (ø)
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 62.30% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 51.03% <100.00%> (+0.04%) ⬆️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@t-kikuc t-kikuc merged commit 9362609 into master Aug 26, 2025
48 checks passed
@t-kikuc t-kikuc deleted the plugin/analysis/sdk-skip branch August 26, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants