Skip to content

[Analysis Plugin] Add Found flag to GetApplicationSharedObject() to distinguish NotFound #6157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-kikuc merged 1 commit into from
Aug 26, 2025
Merged

[Analysis Plugin] Add Found flag to GetApplicationSharedObject() to distinguish NotFound #6157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/app/pipedv1/cmd/piped/grpcapi/plugin_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import (

"go.uber.org/zap"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
)

type PluginAPI struct {
Expand Down Expand Up @@ -164,6 +166,9 @@ func (a *PluginAPI) GetApplicationSharedObject(ctx context.Context, req *service
PluginName: req.PluginName,
Key: req.Key,
})
if status.Code(err) == codes.NotFound {
return nil, status.Error(codes.NotFound, "the requested application shared object was not found")
}
if err != nil {
a.Logger.Error("failed to get application shared object",
zap.String("applicationID", req.ApplicationId),
Expand Down
11 changes: 8 additions & 3 deletions pkg/plugin/sdk/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ import (

"github.com/pipe-cd/piped-plugin-sdk-go/toolregistry"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"

"github.com/pipe-cd/pipecd/pkg/model"
"github.com/pipe-cd/pipecd/pkg/plugin/pipedservice"
Expand Down Expand Up @@ -204,16 +206,19 @@ func (c *Client) GetDeploymentSharedMetadata(ctx context.Context, key string) (s
}

// GetApplicationSharedObject gets the application object which is shared across deployments.
func (c *Client) GetApplicationSharedObject(ctx context.Context, key string) ([]byte, error) {
func (c *Client) GetApplicationSharedObject(ctx context.Context, key string) (obj []byte, found bool, err error) {
resp, err := c.base.GetApplicationSharedObject(ctx, &pipedservice.GetApplicationSharedObjectRequest{
ApplicationId: c.applicationID,
PluginName: c.pluginName,
Key: key,
})
if status.Code(err) == codes.NotFound {
return nil, false, nil
}
if err != nil {
return nil, err
return nil, false, err
}
return resp.Object, nil
return resp.Object, true, nil
}

// PutApplicationSharedObject stores the application object which is shared across deployments.
Expand Down