Skip to content

Remove unused types from pipedv1 config#6160

Merged
khanhtc1202 merged 4 commits into
masterfrom
remove-unused-config-v1
Aug 25, 2025
Merged

Remove unused types from pipedv1 config#6160
khanhtc1202 merged 4 commits into
masterfrom
remove-unused-config-v1

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 commented Aug 25, 2025

What this PR does:

as title

Why we need it:

The removed config will be defined and parsed by plugins.

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 requested a review from a team as a code owner August 25, 2025 12:35
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) August 25, 2025 12:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.56%. Comparing base (006c8aa) to head (b6bc5db).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6160      +/-   ##
==========================================
- Coverage   28.67%   28.56%   -0.11%     
==========================================
  Files         534      534              
  Lines       57346    57123     -223     
==========================================
- Hits        16442    16320     -122     
+ Misses      39626    39538      -88     
+ Partials     1278     1265      -13     
Flag Coverage Δ
. 23.13% <ø> (-0.15%) ⬇️
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 62.30% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.45% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Warashi
Warashi previously approved these changes Aug 25, 2025
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 merged commit 7926e50 into master Aug 25, 2025
45 of 48 checks passed
@khanhtc1202 khanhtc1202 deleted the remove-unused-config-v1 branch August 25, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants