Skip to content

Add setup-go-workspace and teardown-go-workspace commands to Makefile#6166

Merged
t-kikuc merged 1 commit into
masterfrom
add-setup-go-workspace
Aug 28, 2025
Merged

Add setup-go-workspace and teardown-go-workspace commands to Makefile#6166
t-kikuc merged 1 commit into
masterfrom
add-setup-go-workspace

Conversation

@Warashi
Copy link
Copy Markdown
Member

@Warashi Warashi commented Aug 26, 2025

What this PR does:

This PR adds utility target setup-go-workspace and teadown-go-workspace to Makefile

Why we need it:

When we develop a plugin SDK, sometimes we want to test in the development version before merging it.

Which issue(s) this PR fixes:

No issue about this PR

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi Warashi requested a review from a team as a code owner August 26, 2025 02:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.56%. Comparing base (1a0e3c2) to head (c6f693d).
⚠️ Report is 22 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6166   +/-   ##
=======================================
  Coverage   28.56%   28.56%           
=======================================
  Files         535      535           
  Lines       57288    57288           
=======================================
+ Hits        16364    16367    +3     
+ Misses      39652    39649    -3     
  Partials     1272     1272           
Flag Coverage Δ
. 23.13% <ø> (+<0.01%) ⬆️
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.91% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.24% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(unofficial but) LGTM :)

Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems useful

@t-kikuc t-kikuc merged commit 1d245e8 into master Aug 28, 2025
48 checks passed
@t-kikuc t-kikuc deleted the add-setup-go-workspace branch August 28, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants