Skip to content

[k8s plugin] Add custom unmarshal logic for k8s plugin configs#6167

Merged
ffjlabo merged 3 commits into
masterfrom
add-custom-unmarshal-logic
Aug 26, 2025
Merged

[k8s plugin] Add custom unmarshal logic for k8s plugin configs#6167
ffjlabo merged 3 commits into
masterfrom
add-custom-unmarshal-logic

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Aug 26, 2025

What this PR does:

SSIA

Why we need it:

We want to set the default values for configs.

Which issue(s) this PR fixes:

Part of #5764

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
khanhtc1202
khanhtc1202 previously approved these changes Aug 26, 2025
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.55%. Comparing base (1a0e3c2) to head (5490b7d).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...pp/pipedv1/plugin/kubernetes/config/application.go 0.00% 12 Missing ⚠️
.../pipedv1/plugin/kubernetes/config/deploy_target.go 0.00% 12 Missing ⚠️
pkg/app/pipedv1/plugin/kubernetes/config/plugin.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6167      +/-   ##
==========================================
- Coverage   28.56%   28.55%   -0.02%     
==========================================
  Files         535      536       +1     
  Lines       57288    57321      +33     
==========================================
+ Hits        16364    16367       +3     
- Misses      39652    39683      +31     
+ Partials     1272     1271       -1     
Flag Coverage Δ
. 23.13% <ø> (+<0.01%) ⬆️
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.32% <0.00%> (-0.59%) ⬇️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.32% <ø> (+0.07%) ⬆️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Warashi
Warashi previously approved these changes Aug 26, 2025
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo dismissed stale reviews from Warashi and khanhtc1202 via c4edd6e August 26, 2025 02:26
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@Warashi Warashi requested a review from khanhtc1202 August 26, 2025 02:58
@ffjlabo ffjlabo enabled auto-merge (squash) August 26, 2025 02:59
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ffjlabo ffjlabo merged commit 96b29f4 into master Aug 26, 2025
46 of 48 checks passed
@ffjlabo ffjlabo deleted the add-custom-unmarshal-logic branch August 26, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants