Skip to content

Add flag to support migrate multi applications config at once#6181

Merged
khanhtc1202 merged 1 commit into
masterfrom
migrate-app-config-dir
Aug 27, 2025
Merged

Add flag to support migrate multi applications config at once#6181
khanhtc1202 merged 1 commit into
masterfrom
migrate-app-config-dir

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 commented Aug 27, 2025

What this PR does:

Add --dirs flag to pipectl migrate application config command.

Why we need it:

We want to make the pipectl migrate application config command work with multiple applications at once

Which issue(s) this PR fixes:

Part of #5542
Follow #6175

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 requested a review from a team as a code owner August 27, 2025 02:30
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) August 27, 2025 02:30
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.42%. Comparing base (8b0b05c) to head (c90743e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipectl/cmd/migrate/application_config.go 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6181      +/-   ##
==========================================
- Coverage   28.44%   28.42%   -0.03%     
==========================================
  Files         537      537              
  Lines       57534    57566      +32     
==========================================
- Hits        16367    16361       -6     
- Misses      39895    39933      +38     
  Partials     1272     1272              
Flag Coverage Δ
. 23.00% <0.00%> (-0.03%) ⬇️
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.37% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit e7ec5c4 into master Aug 27, 2025
46 of 48 checks passed
@khanhtc1202 khanhtc1202 deleted the migrate-app-config-dir branch August 27, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants