Skip to content

Update migrate app-config command to support migrate skipOn and timeout value in stage config#6182

Merged
khanhtc1202 merged 1 commit into
masterfrom
update-migrate-app-config
Aug 28, 2025
Merged

Update migrate app-config command to support migrate skipOn and timeout value in stage config#6182
khanhtc1202 merged 1 commit into
masterfrom
update-migrate-app-config

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

What this PR does:

Copy STAGE timeout and skipOn config under pipeline.stages[].with to pipeline.stages[] (Application config)

Why we need it:

We decided to make timeout and skipOn options available as stage config for all stages from pipedv1.

We keep the original timeout and skipOn config under pipeline.stages[].with for backward compatibility, in case users want to downgrade pipedv1 to pipedv0.
pipeline.stages[].with.{timeout, skipOn} will be marked as deprecated in v1.

Which issue(s) this PR fixes:

Part of #5542
Follow #6175

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…ut value in stage config

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 requested a review from a team as a code owner August 27, 2025 10:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.64%. Comparing base (e7ec5c4) to head (bbff1f1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6182      +/-   ##
==========================================
+ Coverage   28.43%   28.64%   +0.21%     
==========================================
  Files         537      537              
  Lines       57566    57579      +13     
==========================================
+ Hits        16367    16494     +127     
+ Misses      39927    39809     -118     
- Partials     1272     1276       +4     
Flag Coverage Δ
. 23.28% <100.00%> (+0.26%) ⬆️
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.37% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) August 27, 2025 12:00
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@khanhtc1202 khanhtc1202 merged commit 889123b into master Aug 28, 2025
45 of 48 checks passed
@khanhtc1202 khanhtc1202 deleted the update-migrate-app-config branch August 28, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants