Update migrate app-config command to support migrate skipOn and timeout value in stage config#6182
Merged
Merged
Conversation
…ut value in stage config Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6182 +/- ##
==========================================
+ Coverage 28.43% 28.64% +0.21%
==========================================
Files 537 537
Lines 57566 57579 +13
==========================================
+ Hits 16367 16494 +127
+ Misses 39927 39809 -118
- Partials 1272 1276 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Copy STAGE
timeoutandskipOnconfig underpipeline.stages[].withtopipeline.stages[](Application config)Why we need it:
We decided to make
timeoutandskipOnoptions available as stage config for all stages from pipedv1.We keep the original
timeoutandskipOnconfig underpipeline.stages[].withfor backward compatibility, in case users want to downgrade pipedv1 to pipedv0.pipeline.stages[].with.{timeout, skipOn}will be marked as deprecated in v1.Which issue(s) this PR fixes:
Part of #5542
Follow #6175
Does this PR introduce a user-facing change?: