Skip to content

Handling stage timeout for plugin-arch piped#6183

Merged
khanhtc1202 merged 1 commit into
masterfrom
handle-stage-timeout-pipedv1
Aug 28, 2025
Merged

Handling stage timeout for plugin-arch piped#6183
khanhtc1202 merged 1 commit into
masterfrom
handle-stage-timeout-pipedv1

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

What this PR does:

ssia

Why we need it:

For the new pipedv1, the stage timeout (config via pipeline.stages[].timeout) will be handled by piped, not plugins. This configuration will be available for all stages.

Tested on dev with WAIT stage config duration set to 1h, while stage config timeout to 30s

apiVersion: pipecd.dev/v1beta1
kind: Application
spec:
  name: timeout-test
  pipeline:
    stages:
      - name: WAIT
        timeout: 30s
        with:
          duration: 1h
Screenshot 2025-08-27 at 20 15 03

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 requested a review from a team as a code owner August 27, 2025 11:20
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) August 27, 2025 11:21
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.56%. Comparing base (e7ec5c4) to head (8c0bc0a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/controller/scheduler.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6183      +/-   ##
==========================================
+ Coverage   28.43%   28.56%   +0.13%     
==========================================
  Files         537      531       -6     
  Lines       57566    56736     -830     
==========================================
- Hits        16367    16205     -162     
+ Misses      39927    39280     -647     
+ Partials     1272     1251      -21     
Flag Coverage Δ
. 23.01% <33.33%> (-0.01%) ⬇️
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.37% <ø> (ø)
.-tool-actions-gh-release ?
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khanhtc1202 khanhtc1202 changed the title Handle stage timeout for plugin-arch piped Handling stage timeout for plugin-arch piped Aug 27, 2025
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit e6df612 into master Aug 28, 2025
48 checks passed
@khanhtc1202 khanhtc1202 deleted the handle-stage-timeout-pipedv1 branch August 28, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants