Skip to content

Add support for the {{ .App.Name }} and {{ .K8s.Namespace }} syntax in the query template#6186

Merged
ffjlabo merged 4 commits into
masterfrom
pipedv1-analysis-fill-compat
Aug 28, 2025
Merged

Add support for the {{ .App.Name }} and {{ .K8s.Namespace }} syntax in the query template#6186
ffjlabo merged 4 commits into
masterfrom
pipedv1-analysis-fill-compat

Conversation

@Warashi
Copy link
Copy Markdown
Member

@Warashi Warashi commented Aug 28, 2025

What this PR does:

as title

Why we need it:

To have backword compatibility with pipedv0 for rendering query metrics.
We will deprecate .K8s.Namespace for plugin-arch piped.

Which issue(s) this PR fixes:

Part of #6068
Part of #5542
Follows #6159

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…ax in the query template

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
khanhtc1202
khanhtc1202 previously approved these changes Aug 28, 2025
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.76%. Comparing base (9835164) to head (f28a95d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...p/pipedv1/plugin/analysis/executestage/analysis.go 86.66% 2 Missing ⚠️
pkg/app/pipedv1/plugin/analysis/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6186      +/-   ##
==========================================
+ Coverage   28.73%   28.76%   +0.02%     
==========================================
  Files         557      557              
  Lines       59396    59407      +11     
==========================================
+ Hits        17070    17090      +20     
+ Misses      41017    41008       -9     
  Partials     1309     1309              
Flag Coverage Δ
. 23.28% <ø> (ø)
.-pkg-app-pipedv1-plugin-analysis 32.64% <85.71%> (+0.84%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes 60.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.37% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi requested a review from khanhtc1202 August 28, 2025 08:32
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👌

@ffjlabo ffjlabo merged commit ca55353 into master Aug 28, 2025
45 checks passed
@ffjlabo ffjlabo deleted the pipedv1-analysis-fill-compat branch August 28, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants