Keep pipecd server data even when developer shut down pipecd or kind on local computer#6192
Merged
Warashi merged 5 commits intoSep 14, 2025
Conversation
b4c69ae to
2a916c8
Compare
Okabe-Junya
reviewed
Sep 6, 2025
Member
Okabe-Junya
left a comment
There was a problem hiding this comment.
Really nice improvement!
left just a minor comment, PTAL :)
Signed-off-by: Dan <dangduylinh.bk@gmail.com>
Signed-off-by: Dan <dangduylinh.bk@gmail.com>
Signed-off-by: Dan <dangduylinh.bk@gmail.com>
Signed-off-by: Dan <dangduylinh.bk@gmail.com>
0336766 to
940b309
Compare
…local Signed-off-by: Dan <dangduylinh.bk@gmail.com>
Contributor
Author
|
@Okabe-Junya Thank you. I have just resolve a conflict with master branch. Please check it again 🙇🏼 |
khanhtc1202
approved these changes
Sep 13, 2025
Member
khanhtc1202
left a comment
There was a problem hiding this comment.
Great improvement, thank you 🙌
khanhtc1202
reviewed
Sep 16, 2025
Comment on lines
+52
to
+56
| nodes: | ||
| - role: control-plane | ||
| extraMounts: | ||
| - hostPath: ${VOLUME_MOUNT_POINT} | ||
| containerPath: /tmp/pipecd-data |
Member
There was a problem hiding this comment.
Just realized this only auto creates volumes for Kind, and I'm using Docker4Mac k8s cluster on my local, so I have to do it myself 😂 cc @linhdangduy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
pipecd-data.Why we need it:
On local, every time
make stop/pipecdis executed, all the local data that the developer has "worked hard" to create on the local pipecd server also got lost, then she have to create them all over again on next pipecd run.The root cause is: the mysql, minio, cache storage deployments got restart, and their data also lost.
This PR is for mounting the local volume to storage data in kind cluster, so the data will be kept even when the mysql, minio, cache storage deployments are shut down. When the developer executes
make stop/pipecd, ormake kind-downor even restarts her computer, she would still have all data available on the next run.Which issue(s) this PR fixes:
Solve Item 3 in #6152
Does this PR introduce a user-facing change?:
Test
To test this PR's change, you can do the following step:
make kind-downmake kind-up->make run/pipecd-> port forward ... then access to pipecd webmake stop/pipecd->make kind-down: Turn off pipecd/kindTo confirm the pipecd-data volume content: