Skip to content

[planpreview] Pass runningDS, pipedID and appName from piped#6221

Merged
ffjlabo merged 2 commits into
masterfrom
plugin/planpreview/piped-running-ds
Sep 12, 2025
Merged

[planpreview] Pass runningDS, pipedID and appName from piped#6221
ffjlabo merged 2 commits into
masterfrom
plugin/planpreview/piped-running-ds

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Sep 12, 2025

What this PR does:

Why we need it:

To use them in the k8s plugin

Which issue(s) this PR fixes:

Part of #6217,
Follows #6219
related to #5764

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.77%. Comparing base (0b949bb) to head (3b64e87).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/planpreview/builder.go 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6221      +/-   ##
==========================================
- Coverage   28.77%   28.77%   -0.01%     
==========================================
  Files         559      559              
  Lines       59526    59543      +17     
==========================================
  Hits        17131    17131              
- Misses      41081    41098      +17     
  Partials     1314     1314              
Flag Coverage Δ
. 23.23% <0.00%> (-0.01%) ⬇️
.-pkg-app-pipedv1-plugin-analysis 32.64% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 39.49% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 55.73% <ø> (ø)
.-pkg-plugin-sdk 50.37% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

khanhtc1202
khanhtc1202 previously approved these changes Sep 12, 2025
@t-kikuc t-kikuc enabled auto-merge (squash) September 12, 2025 08:42
@t-kikuc t-kikuc disabled auto-merge September 12, 2025 08:51
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffjlabo ffjlabo merged commit bcce022 into master Sep 12, 2025
43 of 45 checks passed
@ffjlabo ffjlabo deleted the plugin/planpreview/piped-running-ds branch September 12, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants