Skip to content

Rename pipedv1 subcommand from piped to run#6227

Merged
khanhtc1202 merged 1 commit into
masterfrom
rename-piped-sub-command
Sep 16, 2025
Merged

Rename pipedv1 subcommand from piped to run#6227
khanhtc1202 merged 1 commit into
masterfrom
rename-piped-sub-command

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 commented Sep 16, 2025

What this PR does:

ssia

Why we need it:

The PR changes the piped execution command as bellow

old

Usage:
  piped [command]

Available Commands:
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  piped       Start running piped.
  version     Print the information of current binary.

new

Usage:
  piped [command]

Available Commands:
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  run         Start running piped.    <-- this was changed
  version     Print the information of current binary.

This means the piped running command changes from piped piped --flags to piped run --flags.

Tested the helm chart using my locally built chart usingthe following commands

$ make build/chart MOD=pipedv1-exp VERSION=v1.0.0-rc4
$ helm template pipedv1-exp .artifacts/pipedv1-exp-v1.0.0-rc4.tgz --version=v1.0.0-rc4 --namespace=pipecd --create-namespace --set-file config.data=.dev/in-cluster-pipedv1-config.yaml > .dev/piped-template-OUT.yaml
$ less .dev/piped-template-OUT.yaml
...
    spec:
      serviceAccountName: pipedv1-exp
      containers:
        - name: piped
          imagePullPolicy: IfNotPresent
          image: "ghcr.io/pipe-cd/pipedv1-exp:v1.0.0-rc4"
          args:
            - run
            - --config-file=/etc/piped-config/piped-config.yaml
            - --metrics=true
            - --log-encoding=humanize
            - --log-level=info
            - --add-login-user-to-passwd=false
            - --insecure=false
...

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 28.70%. Comparing base (03df4a5) to head (f880195).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6227   +/-   ##
=======================================
  Coverage   28.69%   28.70%           
=======================================
  Files         560      560           
  Lines       59728    59728           
=======================================
+ Hits        17140    17144    +4     
+ Misses      41271    41268    -3     
+ Partials     1317     1316    -1     
Flag Coverage Δ
. 23.23% <0.00%> (ø)
.-pkg-app-pipedv1-plugin-analysis 32.64% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 57.90% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 39.49% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 55.73% <ø> (ø)
.-pkg-plugin-sdk 50.47% <ø> (+0.19%) ⬆️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's describe in the migration guide and v1 docs

Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khanhtc1202 khanhtc1202 merged commit 6ab9a53 into master Sep 16, 2025
44 of 45 checks passed
@khanhtc1202 khanhtc1202 deleted the rename-piped-sub-command branch September 16, 2025 06:35
This was referenced Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants