Change test/lint workflow to correctly report completion status#6257
Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
force-pushed
the
fix-ci-completed-job
branch
from
c84ac5a to
9e14a70
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6257 +/- ##
=======================================
Coverage 28.69% 28.69%
=======================================
Files 560 560
Lines 59738 59738
=======================================
+ Hits 17140 17144 +4
+ Misses 41281 41278 -3
+ Partials 1317 1316 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
khanhtc1202
reviewed
Sep 20, 2025
| # otherwise this job is marked as successful because all steps are skipped | ||
| run: exit 1 | ||
| if: >- | ||
| ${{ |
Member
There was a problem hiding this comment.
Thanks for the patch 👍
I'm not sure this could help, but I checked the CI flow that was supposed to fail due to the test change. It passed anyway because it was not actually running but returned from cache. So maybe even this check doesn't change the issue, wdyt?
https://github.com/pipe-cd/pipecd/actions/runs/17848010213/job/50780173450#step:4:12
Member
Author
There was a problem hiding this comment.
#6253 was merged without passing the tests, and then the CI on the master branch failed.
This PR can fix like this case.
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
khanhtc1202
added a commit
that referenced
this pull request
Sep 24, 2025
* Make quickstart local storage volume off by default (#6240) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * fix: upgrade dayjs from 1.11.13 to 1.11.15 (#6242) Snyk has created this PR to upgrade dayjs from 1.11.13 to 1.11.15. See this package in yarn: dayjs See this project in Snyk: https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Add stale time for fetching in settings-page (#6247) Signed-off-by: kypham <hongkyhvnh@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * fix Details indent (#6248) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Add build plugin as part of build step on CI (#6250) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Ensure to cache plugin go mod in plugin release workflow (#6251) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Get deploy targets by plugin name (#6253) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Fix failed test on CI (#6255) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Fix failed tests on action planpreview (#6256) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Change test/lint workflow to correctly report completion status (#6257) Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update RELEASE to v0.54.2 (#6267) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: kypham <hongkyhvnh@gmail.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: Chris Aniszczyk <caniszczyk@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Ky_pham <57948086+hongky-1994@users.noreply.github.com> Co-authored-by: Tetsuya KIKUCHI <97105818+t-kikuc@users.noreply.github.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
to use it in branch protection rule
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: No