[k8s plugin] Implement ignoring istio virtual service on primary rollout stage#6258
Merged
khanhtc1202 merged 1 commit intoSep 22, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6258 +/- ##
==========================================
+ Coverage 28.69% 28.72% +0.03%
==========================================
Files 560 560
Lines 59738 59754 +16
==========================================
+ Hits 17140 17165 +25
+ Misses 41281 41270 -11
- Partials 1317 1319 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
211d95e to
22d2f4c
Compare
Member
Author
|
@khanhtc1202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implemented the logic to ignore the virtual service from primary manifests.
This logic is implemented on the pipedv0.
pipecd/pkg/app/piped/executor/kubernetes/primary.go
Lines 57 to 86 in e1d78ff
Why we need it:
Which issue(s) this PR fixes:
Part of #5764
Does this PR introduce a user-facing change?: