Skip to content

Update sdk waitapproval#6278

Merged
khanhtc1202 merged 2 commits into
masterfrom
update-sdk-waitapproval
Oct 2, 2025
Merged

Update sdk waitapproval#6278
khanhtc1202 merged 2 commits into
masterfrom
update-sdk-waitapproval

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

What this PR does:

SSIA

Why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 requested a review from a team as a code owner October 1, 2025 04:22
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) October 1, 2025 04:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.76%. Comparing base (0090b2b) to head (c2a2bf2).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...kg/app/pipedv1/plugin/waitapproval/waitapproval.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6278   +/-   ##
=======================================
  Coverage   28.76%   28.76%           
=======================================
  Files         560      560           
  Lines       59834    59838    +4     
=======================================
+ Hits        17209    17215    +6     
+ Misses      41304    41302    -2     
  Partials     1321     1321           
Flag Coverage Δ
. 23.22% <ø> (+0.01%) ⬆️
.-pkg-app-pipedv1-plugin-analysis 32.64% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 58.35% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.63% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 39.56% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 52.71% <0.00%> (-1.69%) ⬇️
.-pkg-plugin-sdk 50.34% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@khanhtc1202 khanhtc1202 merged commit 2b9b723 into master Oct 2, 2025
45 of 46 checks passed
@khanhtc1202 khanhtc1202 deleted the update-sdk-waitapproval branch October 2, 2025 22:24
This was referenced Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants