Skip to content

Change z-index btn menu of application detail#6282

Merged
khanhtc1202 merged 1 commit into
masterfrom
fix-application-detail-z-index-button
Oct 3, 2025
Merged

Change z-index btn menu of application detail#6282
khanhtc1202 merged 1 commit into
masterfrom
fix-application-detail-z-index-button

Conversation

@hongky-1994
Copy link
Copy Markdown
Contributor

What this PR does:

  • Change z-index of button Open menu in application detail page.

Why we need it:

  • Button Open menu of application detail page is behind nodes graph. It should have higher z-index.
CleanShot 2025-10-02 at 15 38 30

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?: No

  • How are users affected by this change: No
  • Is this breaking change: No
  • How to migrate (if breaking change): No

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.76%. Comparing base (0090b2b) to head (0dda796).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6282   +/-   ##
=======================================
  Coverage   28.76%   28.76%           
=======================================
  Files         560      560           
  Lines       59834    59834           
=======================================
+ Hits        17209    17211    +2     
+ Misses      41304    41301    -3     
- Partials     1321     1322    +1     
Flag Coverage Δ
. 23.22% <ø> (+0.01%) ⬆️
.-pkg-app-pipedv1-plugin-analysis 32.64% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 58.35% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.63% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 39.56% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 54.40% <ø> (ø)
.-pkg-plugin-sdk 50.14% <ø> (-0.20%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@khanhtc1202
Copy link
Copy Markdown
Member

@hongky-1994 DCO check is failed, please sign off the commit 🙏

Signed-off-by: kypham <hongkyhvnh@gmail.com>
@hongky-1994 hongky-1994 force-pushed the fix-application-detail-z-index-button branch from 58bd06f to 0dda796 Compare October 2, 2025 11:02
@khanhtc1202 khanhtc1202 merged commit dcbc8d0 into master Oct 3, 2025
46 checks passed
@khanhtc1202 khanhtc1202 deleted the fix-application-detail-z-index-button branch October 3, 2025 02:04
This was referenced Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants