Fix pipedv1 binary showing wrong version#6305
Merged
khanhtc1202 merged 2 commits intoOct 10, 2025
Merged
Conversation
khanhtc1202
reviewed
Oct 10, 2025
Fixes pipe-cd#6297 Signed-off-by: rishabh998186 <rishabh998186@gmail.com.com>
rishabh998186
force-pushed
the
bugfix/pipedv1-version-incorrect
branch
from
afafe88 to
17da42b
Compare
GuruOrGoru
pushed a commit
to GuruOrGoru/pipecd
that referenced
this pull request
Oct 10, 2025
Add version ldflags to plugin build process to inject version, git commit, and build date information during compilation. This fixes the issue where plugin binaries showed 'unspecified' for all version fields. The build/plugin target now includes the same version ldflags as the build/go target, ensuring consistency across all PipeCD binaries. Fixes pipe-cd#6305
GuruOrGoru
pushed a commit
to GuruOrGoru/pipecd
that referenced
this pull request
Oct 10, 2025
Add version ldflags to plugin build process to inject version, git commit, and build date information during compilation. This fixes the issue where plugin binaries showed 'unspecified' for all version fields. The build/plugin target now includes the same version ldflags as the build/go target, ensuring consistency across all PipeCD binaries. Fixes pipe-cd#6305 Signed-off-by: GuruOrGoru <siddharthadhakall3722@gmail.com>
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Built pipedv1 binary shows
v0.54.0-32-ge4f1a5dinstead of correct pipedv1 version.Root Cause: Makefile uses
--match 'v[0-9]*.*'which only matches piped tags, not pipedv1 tags.Solution:
BUILD_VERSIONfixes #6297