Docs-V1: Add Installation Pages#6328
Conversation
|
@eeshaanSA please rebase master to fix the failed tests 👀 |
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
…dv1) Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
bbba0ca to
27e839c
Compare
The build still fails. cc @khanhtc1202 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6328 +/- ##
==========================================
- Coverage 28.82% 28.67% -0.15%
==========================================
Files 560 545 -15
Lines 59937 59016 -921
==========================================
- Hits 17277 16923 -354
+ Misses 41339 40797 -542
+ Partials 1321 1296 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
@khanhtc1202 LGTM! 🚀 |
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
| --set-file config.data={PATH_TO_PIPED_CONFIG_FILE} \ | ||
| --set-file secret.data.piped-key={PATH_TO_PIPED_KEY_FILE} \ | ||
| --set-file secret.data.ssh-key={PATH_TO_PRIVATE_SSH_KEY_FILE} \ | ||
| --set args.enableDefaultKubernetesCloudProvider=false \ |
There was a problem hiding this comment.
| --set args.enableDefaultKubernetesCloudProvider=false \ |
we don't have this flag for pipedv1
ref: https://pipecd.dev/blog/2025/09/02/what-is-new-in-pipedv1-plugin-arch-piped/#weird-flag---enable-default-kubernetes-cloud-provider-in-piped-execution
| branch: {GIT_BRANCH} | ||
| syncInterval: 1m | ||
| plugins: | ||
| - name: kubernetes |
There was a problem hiding this comment.
Should use example plugin to keep this config common 👀
https://github.com/pipe-cd/community-plugins/releases/tag/plugins%2Fexample-stage%2Fv0.1.0
How to use example plugin:
https://github.com/pipe-cd/community-plugins/tree/main/plugins/example-stage
There was a problem hiding this comment.
But without Kubernetes there will not be any deployment targets, and thus application will not be registered?
So is it better to keep both?
something like this:
plugins:
- name: kubernetes
port: 7001
url: https://github.com/pipe-cd/pipecd/releases/download/pkg%2Fapp%2Fpipedv1%2Fplugin%2Fkubernetes%2Fv0.1.0/kubernetes_v0.1.0_darwin_arm64
deployTargets:
- name: local
config:
kubectlVersion: 1.32.4
kubeConfigPath: /Users/sawanteeshaan/.kube/config
- name: example-stage
port: 7002
url: https://github.com/pipe-cd/community-plugins/releases/download/plugins%2Fexample-stage%2Fv0.1.0/example-stage_v0.1.0_darwin_arm64
config:
commonMessage: "Hello Middle Earth! This is the wave from UFO!"
There was a problem hiding this comment.
But without Kubernetes there will not be any deployment targets, and thus application will not be registered?
You're right about that, the expected behavior in that case will be "not possible to register any application for a given piped, because of no deploy target available".
I think at this point, to install piped, you don't need that k8s plugin. Also, on "registering application docs", we will have docs like "you need to ensure your piped configured required plugins to perform your app deployment, please check how to configure piped's plugins for details".
Therefore, I suggest not showing information that is not relevant at the time to minimize confusion.
There was a problem hiding this comment.
Yeah, sounds ideal. I will change it!
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
cc @khanhtc1202 |
khanhtc1202
left a comment
There was a problem hiding this comment.
Let's merge it for now, will update it later 👀
Parent PR: #6316
What this PR does:
Add Installation Pages to support V1
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: