ADD userguide/adding-an-app#6376
Conversation
|
@khanhtc1202, please check! 🙌 |
| {{< tabpane >}} | ||
| {{< tab lang="yaml" header="Kubernetes Application" >}} | ||
| # For application's configuration in detail for a Kubernetes Application, please visit | ||
| # https://pipecd.dev/docs/user-guide/managing-application/defining-app-configuration/kubernetes/ | ||
|
|
||
| apiVersion: pipecd.dev/v1beta1 | ||
| kind: Application | ||
| spec: | ||
| name: foo | ||
| labels: | ||
| team: bar | ||
| {{< /tab >}} | ||
| {{< tab lang="yaml" header="Terraform Application" >}} | ||
|
|
||
| # For application's configuration in detail for Terraform Application, please visit | ||
| # https://pipecd.dev/docs/user-guide/managing-application/defining-app-configuration/terraform/ | ||
|
|
||
| apiVersion: pipecd.dev/v1beta1 | ||
| kind: Application | ||
| spec: | ||
| name: foo | ||
| labels: | ||
| team: bar | ||
| {{< /tab >}} | ||
| {{< /tabpane >}} |
There was a problem hiding this comment.
How about to make prepare piped plugins for your application docs separately and mention it here as pre-require for this docs 👀
There was a problem hiding this comment.
What do you mean? If you want me to add something like a “Prerequisites” section here and link to separate docs about preparing PipeCD plugins?
Or do you mean something else?
There was a problem hiding this comment.
What do you mean? If you want me to add something like a “Prerequisites” section here and link to separate docs about preparing PipeCD plugins?
Yes, this is what I mean 👀
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
eeshaanSA
force-pushed
the
userguide/adding-app
branch
from
c79a3a6 to
ed7afd4
Compare
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
Changges done, please check, @khanhtc1202, Thanks! Happy Holidays! 🎄 |
* ADD userguide/adding-an-app Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com> * UPDATE managing-app.md Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com> --------- Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
|
@eeshaanSA, the image for “Registering an Application from Suggestions” under Adding an application is not loading on the live v1 docs page. |
|
@rahulshendre, sure! Thanks a lot! |
| >**NOTE:** | ||
| >Manually configuring the application on the Control Plane is not supported for PipeCD v1 deployments (deployment using plugins) as of now. We are working on this feature. | ||
|
|
||
| <!-- To define your application deployment pipeline which contains the guideline to show Piped how to deploy your application, please visit [Defining app configuration](../defining-app-configuration/). --> |
There was a problem hiding this comment.
we will also need to comment out this part, it links to defining app configuration.
There was a problem hiding this comment.
@eeshaanSA, we have two issues here:
- Incorrect image path on the live v1 docs
- Reference to "Defining app configuration", which is not live yet
Either we can fix the image issue now in a small PR and handle the documentation section later once the page "Defining app configuration" is live, or do we wait and address both of them together in a single PR?
What would you suggest?
There was a problem hiding this comment.
Yes, Can you please open up issues for both? App configuration is pending, yes, and it should be made soon! Thanks!
There was a problem hiding this comment.
alright, will open up issues for both of them soon : )
3 participants
What this PR does: Add managing-application/adding-an-application
File by file commit from the bigger PR - #6345
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: