ADD userguide/managingApp/triggering-a-deployment#6400
Conversation
|
@eeshaanSA PTAL when you get a chance, and let me know if any changes are required. |
Ayushmore1214
left a comment
Ayushmore1214
left a comment
There was a problem hiding this comment.
@rahulshendre the link for the screenshot of running deployment seems to be broken
|
Also your DCO seems to be failing , make sure to sign that off.... |
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
rahulshendre
force-pushed
the
userguide/managingApp/triggering-a-deployment
branch
from
74c2193 to
39fe99f
Compare
@Ayushmore1214 |
|
@rahulshendre, I have left some suggestions and some comments, so you understand what kind of grammar changes I am looking for, and also understand how the language is supposed to be. PTAL when you have time. :) |
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
Thanks for the suggestions @eeshaanSA |
eeshaanSA
left a comment
eeshaanSA
left a comment
There was a problem hiding this comment.
Please resolve earlier comments, commit the suggested changes, and improve the newer sections highlighted in this review. Thanks!
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
|
Addressed all the review comments and improved readability. PTAL. |
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
…iggering-a-deployment.md Signed-off-by: Eeshaan Sawant <100678386+eeshaanSA@users.noreply.github.com>
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
|
@rahulshendre, you can start working on other pages too. I suggest opening draft PRs for each page (copying them as it is), and then start making your changes, so it is easier to see what changed and how. I will help out with some pages too! Let's get everything ready by EOM. Thanks! |
|
@eeshaanSA Thanks! I’ll start opening draft PRs for the remaining pages shortly. |
| - `onOutOfSync`: Triggers a deployment when the application enters an OUT_OF_SYNC state. | ||
| - `onChain`: Triggers a deployment when the application is part of a deployment chain. | ||
|
|
||
| For the full list of options, see [Configuration Reference](../../configuration-reference/#deploymenttrigger). |
There was a problem hiding this comment.
Not sure this link could be available for v1 docs but let merge and check this @rahulshendre @eeshaanSA
4 participants
What this PR does:
File by file commit from the bigger PR - #6345
Adds the “Triggering a deployment” page under User Guide → Managing Application.
Related to #6395
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: