Skip to content

Apply default values in Terraform and CloudRun Deployment plugin#6516

Merged
Warashi merged 2 commits into
pipe-cd:masterfrom
rawadhossain:deployPlugins-defaults
Mar 14, 2026
Merged

Apply default values in Terraform and CloudRun Deployment plugin#6516
Warashi merged 2 commits into
pipe-cd:masterfrom
rawadhossain:deployPlugins-defaults

Conversation

@rawadhossain
Copy link
Copy Markdown
Contributor

What this PR does:
Implements setting default values in the CloudRun and Terraform deployment plugins by adding UnmarshalJSON methods that call defaults.Set().

Why we need it:

  • CloudRun’s ServiceManifestFile was documented to default to service.yaml, but the default was never applied.
  • Terraform’s DriftDetectionEnabled had a default true tag but the value was never set during unmarshaling.

Part of Issue #6174

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
    • CloudRun configs that omit serviceManifestFile will now correctly default to service.yaml
    • Terraform deploy target configs that omit driftDetectionEnabled will now correctly default to true
  • Is this breaking change: No
  • How to migrate (if breaking change): N/A

Signed-off-by: Rawad Hossain <rawad.hossain00@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Mar 10, 2026
@rawadhossain
Copy link
Copy Markdown
Contributor Author

Hi @Warashi, just checking in since it was marked stale and may auto close soon.
Would appreciate your review or any feedback when you have time. I'm happy to make changes if needed. Thanks.

@github-actions github-actions Bot removed the Stale label Mar 11, 2026
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi enabled auto-merge (squash) March 14, 2026 03:59
@Warashi Warashi merged commit 0a2f5f8 into pipe-cd:master Mar 14, 2026
61 of 63 checks passed
@github-actions github-actions Bot mentioned this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants