Skip to content

[ECS-Plugin] Fix lint#6588

Merged
Warashi merged 2 commits into
pipe-cd:masterfrom
armistcxy:ecs-plugin/filter-tasksets
Mar 14, 2026
Merged

[ECS-Plugin] Fix lint#6588
Warashi merged 2 commits into
pipe-cd:masterfrom
armistcxy:ecs-plugin/filter-tasksets

Conversation

@armistcxy
Copy link
Copy Markdown
Contributor

@armistcxy armistcxy commented Mar 14, 2026

What this PR does: Fix lint issues and return filter tasksets instead of raw ones and

Why we need it:

.golangci.yml required internal imports from pipecd must be seperated into a new group

Rerun goimports with flag -local

The function GetServiceTaskSets does not return filtered tasksets (tasksets managed by pipecd)
This causes both lint error and wrong purpose

	taskSets := make([]types.TaskSet, 0, len(tsOutput.TaskSets))
	for i := range tsOutput.TaskSets {
		if !IsPipeCDManagedTaskSet(&tsOutput.TaskSets[i]) {
			continue
		}
		taskSets = append(taskSets, tsOutput.TaskSets[i])
	}

	return svc.TaskSets, nil

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
@armistcxy armistcxy requested a review from a team as a code owner March 14, 2026 05:46
@armistcxy armistcxy changed the title [ECS-Plugin] Returning filtered TaskSets [ECS-Plugin] Fix lint Mar 14, 2026
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
@armistcxy armistcxy force-pushed the ecs-plugin/filter-tasksets branch from 53033ac to 71deb77 Compare March 14, 2026 06:07
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@Warashi Warashi enabled auto-merge (squash) March 14, 2026 06:40
@Warashi Warashi merged commit 25601c8 into pipe-cd:master Mar 14, 2026
61 of 63 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.34%. Comparing base (6e9dbf7) to head (71deb77).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6588       +/-   ##
===========================================
+ Coverage   28.82%   50.34%   +21.52%     
===========================================
  Files         575       18      -557     
  Lines       60858     2020    -58838     
===========================================
- Hits        17542     1017    -16525     
+ Misses      41982      962    -41020     
+ Partials     1334       41     -1293     
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-analysis ?
.-pkg-app-pipedv1-plugin-ecs ?
.-pkg-app-pipedv1-plugin-kubernetes ?
.-pkg-app-pipedv1-plugin-kubernetes_multicluster ?
.-pkg-app-pipedv1-plugin-scriptrun ?
.-pkg-app-pipedv1-plugin-terraform ?
.-pkg-app-pipedv1-plugin-wait ?
.-pkg-app-pipedv1-plugin-waitapproval ?
.-pkg-plugin-sdk 50.34% <ø> (ø)
.-tool-actions-gh-release ?
.-tool-actions-plan-preview ?
.-tool-codegen-protoc-gen-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot mentioned this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants