[ECS-Plugin] Fix lint#6588
Merged
Merged
Conversation
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
Signed-off-by: Hoang Ngo <adlehoang118@gmail.com>
53033ac to
71deb77
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6588 +/- ##
===========================================
+ Coverage 28.82% 50.34% +21.52%
===========================================
Files 575 18 -557
Lines 60858 2020 -58838
===========================================
- Hits 17542 1017 -16525
+ Misses 41982 962 -41020
+ Partials 1334 41 -1293 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Fix lint issues and return filter tasksets instead of raw ones and
Why we need it:
.golangci.ymlrequired internal imports from pipecd must be seperated into a new groupRerun
goimportswith flag-localThe function
GetServiceTaskSetsdoes not return filtered tasksets (tasksets managed by pipecd)This causes both lint error and wrong purpose
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: