[Multi_K8s-Plugin] Config hash for StatefulSet and DaemonSet#6697
Merged
khanhtc1202 merged 2 commits intoApr 21, 2026
Merged
Conversation
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
mohammedfirdouss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Extends the config hash annotation feature in the
kubernetes_multiclusterplugin to cover StatefulSet and DaemonSet workloads, in addition to the existing Deployment support.When a ConfigMap or Secret referenced by a workload changes, PipeCD annotates the workload's pod template with a hash of the config content triggering a rollout automatically. Before this change, only Deployments received this annotation. StatefulSets and DaemonSets were silently skipped (a TODO comment in
annotate.goline 55 noted this gap).Why we need it:
StatefulSets and DaemonSets can reference ConfigMaps and Secrets just like Deployments. Without this fix, changes to those config resources would not trigger a restart of StatefulSet or DaemonSet pods, leaving them running stale configuration silently.
Which issue(s) this PR fixes:
Related to #6446
Does this PR introduce a user-facing change?: