fix: FindReferencingConfigMaps and FindReferencingSecrets to scan Cro…#6762
fix: FindReferencingConfigMaps and FindReferencingSecrets to scan Cro…#6762Ram04102007 wants to merge 2 commits into
Conversation
…nJob jobTemplate Signed-off-by: Sriram Thiruveedhula <sriram.thiruveedhula2007@gmail.com>
52638b5 to
0d88c4a
Compare
|
The PR also adds |
|
Thanks for the review! You're right — I noticed the same thing. I can either strip them out and keep this PR focused purely on What works better for you? |
…figmaps-secrets-cronjob
8c2c0a5 to
d1674fd
Compare
What this PR does / why we need it
Fixes #6761
While looking at the code after #6528 was fixed, I noticed that
FindReferencingConfigMaps and FindReferencingSecrets have the same
gap — they don't handle CronJobs.
Both functions only walked spec.template.spec.* paths, which works for
Deployments, StatefulSets, and DaemonSets. CronJob wraps its pod template
under spec.jobTemplate.spec.template.spec.*, so all ConfigMap/Secret
references inside a CronJob were silently missed.
Added the missing nestedStringSlice probes for all jobTemplate paths
in both functions, across both kubernetes and kubernetes_multicluster
provider packages. 10 new test cases added, all passing.
Does this PR introduce a user-facing change?
Yes — PipeCD now correctly detects ConfigMap/Secret references in CronJobs,
enabling proper drift detection and re-deploy triggering for CronJob workloads.