[Multi_K8s-Plugin] Surface partial deletion errors in deleteResources#6781
Open
mohammedfirdouss wants to merge 2 commits into
Open
[Multi_K8s-Plugin] Surface partial deletion errors in deleteResources#6781mohammedfirdouss wants to merge 2 commits into
mohammedfirdouss wants to merge 2 commits into
Conversation
mohammedfirdouss
force-pushed
the
feat/fix-delete-resources-errors
branch
from
a4843b4 to
d4d78b4
Compare
mohammedfirdouss
force-pushed
the
feat/fix-delete-resources-errors
branch
from
d4d78b4 to
f1399a5
Compare
…teResources Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
mohammedfirdouss
force-pushed
the
feat/fix-delete-resources-errors
branch
from
f1399a5 to
8108439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes
deleteResourcesindeployment/misc.goto return(int, error)instead of justint. All deletion errors are now collected viaerrors.Joinand returned to callers.deleteVariantResourcespropagates combined errors. Stage functions (sync,primaryRollout) now fail the stage if any resource deletion fails rather than silently succeeding with a partial count.Why we need it:
Previously, when deleting multiple resources (during prune or variant cleanup), any non-
ErrNotFounderror was logged but swallowed callers received only the success count and logged "Successfully deleted X resources" with no signal that some resources failed. A partially-failed cleanup appeared as a success.Which issue(s) this PR fixes:
Fixes #6446
Does this PR introduce a user-facing change?: