[Multi_K8s-Plugin] Fix livestate loadManifests to stamp tracking labels and honour kustomizeDir#6783
Open
mohammedfirdouss wants to merge 1 commit into
Conversation
7ee1a93 to
f717734
Compare
f717734 to
e4ad1bb
Compare
…izeDir in livestate loadManifests Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
e4ad1bb to
c8a3dc8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #6783 +/- ##
===========================================
- Coverage 29.33% 17.50% -11.84%
===========================================
Files 598 7 -591
Lines 63902 920 -62982
===========================================
- Hits 18744 161 -18583
+ Misses 43711 738 -42973
+ Partials 1447 21 -1426 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes
loadManifestsinlivestate/plugin.goto match whatdeployment/plugin.goalready does:kustomizeDirfrom the per-targetmultiTargetconfig previously the field was ignored, so kustomize overlay directories set per-target had no effect in livestate.LabelManagedBy,LabelPiped,LabelApplication,LabelCommitHash,LabelOriginalAPIVersion,LabelResourceKey) on every loaded manifest previously these were missing, causing a divergence between the manifests the deployment plugin applies and the manifests livestate uses for drift detection.Why we need it:
The deployment and livestate plugins use separate
loadManifestsimplementations that had diverged. Missing labels in the livestate version meant drift detection compared against manifests that lacked the builtin PipeCD tracking labels, potentially causing false drift reports or missed drift. MissingkustomizeDirmeant per-target kustomize overlays were silently ignored during livestate checks.Which issue(s) this PR fixes:
Fixes #6446
Does this PR introduce a user-facing change?: