Skip to content

Fix CocoaPods path transformation#848

Merged
xtreme-shane-lattanzio merged 1 commit intopivotal:masterfrom
majd:fix/cocoapods
Aug 18, 2021
Merged

Fix CocoaPods path transformation#848
xtreme-shane-lattanzio merged 1 commit intopivotal:masterfrom
majd:fix/cocoapods

Conversation

@majd
Copy link
Contributor

@majd majd commented Aug 13, 2021

This PR fixes two issues when reading the Pods-*-acknowledgements.plist file:

  1. Updates the regular expression to not replace whitespaces (ex. Target Support Files).
  2. When gsub returns nil if no matches were found in the pathname, it should default to the original value.

@pivotal-cla
Copy link

@majd Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@majd Thank you for signing the Contributor License Agreement!

@xtreme-shane-lattanzio xtreme-shane-lattanzio merged commit 3428ccd into pivotal:master Aug 18, 2021
@majd majd deleted the fix/cocoapods branch August 18, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants