Add command creation callback#10
Open
Bodix wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a problem with the initialization order when using dependency injection (in my case, Zenject). The problem is that the
OnCommandsCreatedcallback is called too late for Zenject. Some internal logic is executed before it (namely, the command variable change callbacks registered to theOnValueChangedattribute), which may require dependencies that Zenject should have provided. This causes aNullReferenceException.Initialization order of command:
NullReferenceExceptionbecausethe command dependencies have not yet been injected.
So I created the
OnCommandCreatedcallback, which is invoked per command before any internal callback.Also, I recommend renaming the previous
OnCommandsCreatedtoOnCommandsInitializedto distinguish between creation and initialization. Same with theHasCommandsCreatedproperty (toHasCommandsInitialized). I didn't do it because it is breaking changes, and I don't know your package update pipeline.