Skip to content

Add capability to get pod labels - #468

Closed
tharinduwijewardane wants to merge 4 commits into
pixie-io:mainfrom
tharinduwijewardane:main_podLabels
Closed

Add capability to get pod labels#468
tharinduwijewardane wants to merge 4 commits into
pixie-io:mainfrom
tharinduwijewardane:main_podLabels

Conversation

@tharinduwijewardane

@tharinduwijewardane tharinduwijewardane commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

Fixes: #449

Example script:

import px
df = px.DataFrame(table='http_events', start_time='-10s')
df.labels = px.pod_id_to_pod_labels(df.ctx['pod_id'])
px.display(df)

Output:
Screenshot from 2022-06-22 23-48-42

@tharinduwijewardane
Add capability to get pod labels
28a5deb 
Signed-off-by: Tharindu Wijewardane <tharindu.moratuwa@gmail.com>
@tharinduwijewardane
tharinduwijewardane requested a review from a team as a code owner June 22, 2022 18:39
@pixie-io-buildbot

pixie-io-buildbot commented Jun 22, 2022

Copy link
Copy Markdown
Member

Can one of the admins verify this patch?

@zasgar
zasgar self-requested a review June 22, 2022 19:04
@zasgar

zasgar commented Jun 22, 2022

Copy link
Copy Markdown
Member

ok to test

zasgar
zasgar requested changes Jun 22, 2022
View reviewed changes
Comment thread src/carnot/funcs/metadata/metadata_ops_test.cc Outdated
@zasgar

zasgar commented Jun 22, 2022

Copy link
Copy Markdown
Member

Thanks a lot for the contribution. This looks great. There is a just a small bug with one of the tests and then it should be good to go.

@tharinduwijewardane
Fix a mistake in a test case json string
bfad2e1 
Signed-off-by: Tharindu Wijewardane <tharindu.moratuwa@gmail.com>
@zasgar

zasgar commented Jun 23, 2022

Copy link
Copy Markdown
Member

Ok to test

vihangm
vihangm requested changes Jun 25, 2022
View reviewed changes

@vihangm vihangm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Need a couple of small changes to fix a broken test and then we can merge this in!

Comment thread src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_handler.go Outdated
Comment thread src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_handler_test.go Outdated
@tharinduwijewardane
Add null check for pod.Metadata.Labels
233860d 
Signed-off-by: Tharindu Wijewardane <tharindu.moratuwa@gmail.com>
@tharinduwijewardane
Fix k8smeta_test
4c27441 
Signed-off-by: Tharindu Wijewardane <tharindu.moratuwa@gmail.com>
@pixie-io-buildbot

pixie-io-buildbot commented Jun 26, 2022

Copy link
Copy Markdown
Member

Build Passed

orishuss pushed a commit to orishuss/pixie that referenced this pull request Jul 14, 2022
@tharinduwijewardane @orishuss
Add capability to get pod labels
09ff178 
Summary:
Track pod labels and adds a UDF to get pod labels given IDs.

Fixes pixie-io#449
Closes pixie-io#468

Test Plan: Added unit tests

Reviewers: zasgar, michelle

Reviewed By: michelle

Signed-off-by: Tharindu Wijewardane <tharindu.moratuwa@gmail.com>

Differential Revision: https://phab.corp.pixielabs.ai/D11678

GitOrigin-RevId: fd84b4d
orishuss pushed a commit to orishuss/pixie that referenced this pull request Jul 14, 2022
@tharinduwijewardane @orishuss
Add capability to get pod labels
359bf4b 
Summary:
Track pod labels and adds a UDF to get pod labels given IDs.

Fixes pixie-io#449
Closes pixie-io#468

Test Plan: Added unit tests

Reviewers: zasgar, michelle

Reviewed By: michelle

Signed-off-by: Tharindu Wijewardane <tharindu.moratuwa@gmail.com>

Differential Revision: https://phab.corp.pixielabs.ai/D11678

GitOrigin-RevId: fd84b4d
orishuss pushed a commit to orishuss/pixie that referenced this pull request Jul 14, 2022
@tharinduwijewardane @orishuss
Add capability to get pod labels
8f969d2 
Summary:
Track pod labels and adds a UDF to get pod labels given IDs.

Fixes pixie-io#449
Closes pixie-io#468

Test Plan: Added unit tests

Reviewers: zasgar, michelle

Reviewed By: michelle

Signed-off-by: Tharindu Wijewardane <tharindu.moratuwa@gmail.com>

Differential Revision: https://phab.corp.pixielabs.ai/D11678

GitOrigin-RevId: fd84b4d
@htroisi htroisi mentioned this pull request Aug 25, 2022
Open
entlein pushed a commit to k8sstormcenter/pixie that referenced this pull request Jun 2, 2026
@tharinduwijewardane @copybaranaut
Add capability to get pod labels
ea36f65 
Summary:
Track pod labels and adds a UDF to get pod labels given IDs.

Fixes pixie-io#449
Closes pixie-io#468

Test Plan: Added unit tests

Reviewers: zasgar, michelle

Reviewed By: michelle

Signed-off-by: Tharindu Wijewardane <tharindu.moratuwa@gmail.com>

Differential Revision: https://phab.corp.pixielabs.ai/D11678

GitOrigin-RevId: fd84b4d
@nyadav4-ai nyadav4-ai mentioned this pull request Jul 26, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vihangm vihangm vihangm approved these changes
@zasgar zasgar Awaiting requested review from zasgar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide pod labels with metadata

4 participants

@tharinduwijewardane @pixie-io-buildbot @zasgar @vihangm