Conversation
Co-authored-by: Zhenwei Jin <109658203+kylo5aby@users.noreply.github.com>
ljharb
approved these changes
Jun 27, 2025
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Love it! Confirmed it matches the node commit.
Collaborator
Author
|
oh, should update the readme too I guess edit: done |
shadowspawn
approved these changes
Jun 27, 2025
Collaborator
shadowspawn
left a comment
shadowspawn
left a comment
There was a problem hiding this comment.
LGTM, thanks @bakkot
Collaborator
Author
|
Gonna go ahead and click the merge button. I'm not sure how releases here work. Looks like there's a github workflow referencing an archived action? Anyway I think it would be good to do a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160; cc @ljharb.
Direct port of nodejs/node#53107. Node is MIT licensed, same as this project, so that should be kosher. I added the original author as a coauthor on the commit.