-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Description
Context
platform-mesh/golang-commons#164 replaces the viper-based config system with explicit pflag registration. This removes AutomaticEnv() support, meaning environment variables are no longer automatically mapped to config fields.
Problem
The common chart templates currently inject configuration via environment variables that operators previously consumed through viper:
_deploymentHelpers.tpl— injectsCOLLECTOR_SERVICE_NAME,COLLECTOR_SERVICE_VERSION,COLLECTOR_ENDPOINT
After the golang-commons change, these env vars will be silently ignored, breaking tracing collector config in all deployed operators.
Required Changes
Update the common chart templates to pass these values as CLI args:
args:
- --tracing-config-service-name=$(COLLECTOR_SERVICE_NAME)
- --tracing-config-service-version=$(COLLECTOR_SERVICE_VERSION)
- --tracing-config-collector-endpoint=$(COLLECTOR_ENDPOINT)Sentry DSN will be handled via explicit env var fallback in golang-commons (secrets should not be passed as CLI args).
Related
- feat: change default config setup golang-commons#164
- platform-mesh/backlog#175
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels