Kill and auto-restart process after copying mounts#82
Open
doender wants to merge 2 commits intoplatformsh-templates:masterfrom
Open
Kill and auto-restart process after copying mounts#82doender wants to merge 2 commits intoplatformsh-templates:masterfrom
doender wants to merge 2 commits intoplatformsh-templates:masterfrom
Conversation
doender
changed the title
doender
changed the title
|
This is basically required, so this should get merged. |
|
Would a symptom, possibly fixed by this solution be that the _buildManifest.js and _ssgManifest.js are returning a 404? I am occasionally encountering this problem after deployment, and I believe that restarting the server might be one way to solve it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because the files from the temporary directory are copied after the process has been started (in the deploy hook), the process starts based on the wrong files. My hypothesis is that the very first time this doesn't cause issues as the process will crash (because there's no build folder), and an automatic restart will fix the situation. However, with an existing build the process will not crash and there will be inconsistencies between the process and the build folder. The proposed fix is to kill the process in the deploy hook after the files have been copied, so an automatic restart will cause the process the start with the new build folder.
Related Issue
#62
How Has This Been Tested?
I tested it in a clean environment with consecutive builds