Skip to content

Remove stale 'stub' / TODO comments on already-implemented modules #29

Description

@amondnet

Summary

Several modules carry "Minimal stub" / TODO(integration) / "throwing stub" comments that are stale — the code is fully implemented. These mislead readers (and audits) into thinking work is incomplete. Pure comment cleanup, no behavior change.

Stale markers to remove/update

  • src/types.ts:2// Minimal stub — full implementation lands in Unit 1. → file is fully implemented (chunkToDict, chunkFromDict, searchResultToDict, …).
  • src/utils.ts:2// Minimal stub — full implementation lands in Unit 3. → fully implemented (isGitUrl, resolveChunk, formatResults, …).
  • src/cli.ts:8// TODO(integration): replace stub when sibling modules land → all sibling modules are imported and real.
  • src/indexing/index.ts:7-13 — header says fromGit: stub (T005) and loadFromDisk: throwing stub (T007), but both are fully implemented (fromGit at :196, loadFromDisk at :389). Update the "Wiring status" block.

Out of scope

The genuine functional stubs are tracked separately:

Acceptance criteria

  • Stale stub/TODO comments above removed or corrected to reflect implemented state.
  • No code/behavior changes; bun run typecheck + bun test still green.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersp3Priority 3 - Lowtype:docsDocumentation improvements

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions