change "variable" to "name" - #31
Closed
saycheeseter wants to merge 1 commit into
Closed
Conversation
civan
reviewed
Oct 25, 2017
civan
left a comment
civan
left a comment
Member
There was a problem hiding this comment.
Hi there, thanks for this changes, looking great, can you take a look at my comments?
|
|
||
| ### Map support | ||
| In case you wanted your sass Maps variable to be an array we included te **mapValue** property for variables identified as maps. | ||
| In case you wanted your sass Maps name to be an array we included te **mapValue** property for variables identified as maps. |
Member
There was a problem hiding this comment.
I don't think you should change 'variable' here.
| let map = this.extractMapDeclarations(parsed.value); | ||
|
|
||
| // in case the variable is a sass map | ||
| // in case the name is a sass map |
Member
There was a problem hiding this comment.
also this 'variable' should not change
| let map = this.extractMapDeclarations(parsed.value); | ||
|
|
||
| // in case the variable is a sass map | ||
| // in case the name is a sass map |
| $second-variable: red; | ||
| $global-variable: #123; // inline comment here | ||
| $references: $second-variable; | ||
| $second-name: red; |
Member
There was a problem hiding this comment.
'variable' here should not change in this file
civan
requested changes
Oct 25, 2017
civan
left a comment
civan
left a comment
Member
There was a problem hiding this comment.
hey there, can you also update this request against master?
thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.