Skip to content

WIP - Integrate buildoutcoredevdocs#1670

Closed
polyester wants to merge 14 commits into
6.0from
integrate-buildoutcoredevdocs
Closed

WIP - Integrate buildoutcoredevdocs#1670
polyester wants to merge 14 commits into
6.0from
integrate-buildoutcoredevdocs

Conversation

@polyester

Copy link
Copy Markdown
Member

Integrate the documents from buildout.coredev. They are now placed under /contribute/core and have been moderated, checked for readability and relevancy.

Work in progress - a second pair of eyes is very welcome.

@polyester polyester requested a review from stevepiercy June 17, 2024 13:45
@polyester polyester changed the title Integrate buildoutcoredevdocs WIP - Integrate buildoutcoredevdocs Jun 17, 2024
@stevepiercy

Copy link
Copy Markdown
Member

For a review, I will make a new branch from this one, then create a PR against it. This is a big one, and a GitHub's web UI is not as good as PyCharm's for this. It might take me a day or two to complete.

@stevepiercy

Copy link
Copy Markdown
Member

Just a couple of quick comments for now, more coming later.

There are a lot of whitespace reformats going on that make a review difficult. I'm going to revert the whitespace changes so I can focus on things that matter. If your editor reformats whitespace, please turn it off, as we don't have any standard and we will end up clobbering each others' editor preferences.

The submodules should never be committed to a PR.

@stevepiercy

Copy link
Copy Markdown
Member

I give up. I don't know how to remove the committed submodules. Instead I'm just going to close this PR, and create a new branch from 6.0 with only the files from this PR.

stevepiercy added a commit that referenced this pull request Jun 19, 2024
stevepiercy added a commit that referenced this pull request Jul 20, 2024
@stevepiercy stevepiercy deleted the integrate-buildoutcoredevdocs branch July 20, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants