Skip to content

Package building isn't part of our CI. #300

Description

@mkcor

Whenever we change JS code, we rebuild the package by running

npm run build:all

which results in dash_bio/bundle.js. If this breaks, we have a broken package. Therefore, it is important to make this command part of CI (it's currently missing in our CI config).

Not only do we want to double check builds that were successful locally (maybe our dev environments aren't fully up-to-date and/or we don't run both Python 3.6 and Python 3.7), but we also want PRs from the Renovate Bot (dependency updates, such #299 and #284) to go through the full pipeline.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions