Prettier setup#119
Merged
Merged
Conversation
shammamah-zz
left a comment
Contributor
There was a problem hiding this comment.
Thanks for setting this up! 👍
| "format:test": "prettier --config .prettierrc --list-different \"{src/**/, src/lib/components/}*.js\"", | ||
| "format": "prettier --config .prettierrc --write \"{src/**/, src/lib/components/}*.js\"", | ||
| "lint:test": "eslint src", | ||
| "lint": "eslint src --fix", |
Contributor
There was a problem hiding this comment.
We could add these to some of the build scripts too so they are done automatically, what do you think?
Contributor
Author
There was a problem hiding this comment.
To me it sounds like a good idea :)
…gin-react#configuration to detect local react version
Contributor
|
Hurray for pretty code 💃 |
shammamah-zz
approved these changes
Jan 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dash Bio pull request
fix #112 by setting up prettier
and possibly add it to(e52d8cb)CONTRIBUTE.mdnpm run formatandnpm run linton the repo and push the changes (7fae912 and 03058a2)Before asking for a review
PR merging checklist
Please make sure you have done these things before asking for approval to finally merge.
master: check out the master branch withgit checkout master, pull the latest changes withgit pull origin master, check out back to your branch withgit checkout your-branch, merge (latest) master into your branch withgit merge master. Resolve conflicts if there are any, and finallygit push origin your-branch.package-lock.json(runnpm install)npm run build:allor `npm run build:python setup.py sdist, then copydist/dash_bio-X.Y.Z.tar.gzinto the top-level directory)pip install dash-bio-X.Y.Z.tar.gz)dash_bio/subfolder by the above command(s)DDS Deployment
developersuser credentials, have them ready.git push dash-bio master.