Skip to content

Prettier setup#119

Merged
Bachibouzouk merged 10 commits into
masterfrom
prettier_setup
Jan 23, 2019
Merged

Prettier setup#119
Bachibouzouk merged 10 commits into
masterfrom
prettier_setup

Conversation

@Bachibouzouk

@Bachibouzouk Bachibouzouk commented Jan 23, 2019

Copy link
Copy Markdown
Contributor

Dash Bio pull request

fix #112 by setting up prettier

  • : verify the dependencies (7ead816)
  • : find what scripts to run and test the scripts locally (5a2688b)
  • : find out when should the scripts be ran and possibly add it to CONTRIBUTE.md (e52d8cb)
  • : run npm run format and npm run lint on the repo and push the changes (7fae912 and 03058a2)

Before asking for a review

PR merging checklist

Please make sure you have done these things before asking for approval to finally merge.

  • Address all comments in the code review.
  • Make sure you are up-to-date with the latest master: check out the master branch with git checkout master, pull the latest changes with git pull origin master, check out back to your branch with git checkout your-branch, merge (latest) master into your branch with git merge master. Resolve conflicts if there are any, and finally git push origin your-branch.
  • Update/regenerate package-lock.json (run npm install)
  • Rebuild (run npm run build:all or `npm run build:
  • Regenerate tarball (run python setup.py sdist, then copy dist/dash_bio-X.Y.Z.tar.gz into the top-level directory)
  • Ensure that you installed the tarball you generated with the above commands (run pip install dash-bio-X.Y.Z.tar.gz)
  • Run your application successfully in a virtual environment and test that other apps still run
  • Commit and push the files that were generated in the dash_bio/ subfolder by the above command(s)
  • Ask for a final review and look for a 💃!
  • Have your dancer? Merge to master!

DDS Deployment

  • You will be asked to enter the developers user credentials, have them ready.
  • Push local master to the dds dash-bio master: git push dash-bio master.

@mtwichan
mtwichan temporarily deployed to dash-bio-test-pr-119 January 23, 2019 14:54 Inactive
@mtwichan
mtwichan temporarily deployed to dash-bio-test-pr-119 January 23, 2019 14:56 Inactive

@shammamah-zz shammamah-zz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this up! 👍

Comment thread package.json
"format:test": "prettier --config .prettierrc --list-different \"{src/**/, src/lib/components/}*.js\"",
"format": "prettier --config .prettierrc --write \"{src/**/, src/lib/components/}*.js\"",
"lint:test": "eslint src",
"lint": "eslint src --fix",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add these to some of the build scripts too so they are done automatically, what do you think?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it sounds like a good idea :)

@mtwichan
mtwichan temporarily deployed to dash-bio-test-pr-119 January 23, 2019 21:37 Inactive
@shammamah-zz

Copy link
Copy Markdown
Contributor

Hurray for pretty code 💃

@Bachibouzouk
Bachibouzouk merged commit 747cc4a into master Jan 23, 2019
@Bachibouzouk
Bachibouzouk deleted the prettier_setup branch February 1, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up Prettier for JS components.

3 participants