Let CI run Python unit tests#463
Conversation
954171b to
d7d1958
Compare
I don't think so. The unit tests are meant to test components individually. Some of those components are written in Python instead of JS, but that doesn't mean they're two different types of tests. |
Oops, I have rebased and edited the description (see above) before seeing your comment... I agree they are both unit tests, but since the CI config is structured into |
There was a problem hiding this comment.
💃 LGTM. One tiny bit more sanity.
I have no preference as to whether the Py unit tests and the JS unit tests should be executed together. Dividing JS / Py seems ok for now. Some projects in Dash combine them, some don't, based on the current structure.
|
@shammamah by the way ;)
This is not correct. Unit tests are meant to test code units (such as functions). The component level does not come into play; for convenience, we can use it in the file structure of course (e.g., file |
Closes #462.
About
Description of changes
I was quite tempted to add a Python command right next topython unit_test_data_setup.py. Instead, should we separate Python unit tests and JS unit tests into two different steps?Oops, that step of running Python unit tests definitely can't be part of a
nodejob! I have rebased.Before merging