-
-
Notifications
You must be signed in to change notification settings - Fork 196
Remove duplicate package.json, update readme. #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| include {{cookiecutter.project_shortname}}/{{cookiecutter.project_shortname}}.min.js | ||
| include {{cookiecutter.project_shortname}}/{{cookiecutter.project_shortname}}.dev.js | ||
| include {{cookiecutter.project_shortname}}/metadata.json | ||
| include {{cookiecutter.project_shortname}}/package.json | ||
| include package.json | ||
| include README.md |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,11 @@ | ||
| import json | ||
| import os | ||
| from setuptools import setup | ||
|
|
||
|
|
||
| with open(os.path.join('{{cookiecutter.project_shortname}}', 'package.json')) as f: | ||
| with open('package.json') as f: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| package = json.load(f) | ||
|
|
||
| package_name = package["name"].replace(" ", "_").replace("-", "_") | ||
| package_name = str(package["name"].replace(" ", "_").replace("-", "_")) | ||
|
|
||
| setup( | ||
| name=package_name, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ | |
| _sys.exit(1) | ||
|
|
||
| _basepath = _os.path.dirname(__file__) | ||
| _filepath = _os.path.abspath(_os.path.join(_basepath, 'package.json')) | ||
| _filepath = _os.path.abspath(_os.path.join(_basepath, '..','package.json')) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm will this actually work once the package is installed via
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this is why that
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll add a test that will package the build and run an app with it installed as a tarball. |
||
| with open(_filepath) as f: | ||
| package = json.load(f) | ||
|
|
||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment in plotly/dash#451