Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Fix monorepo build#115

Merged
Marc-Andre-Rivet merged 2 commits into
masterfrom
fix-monorepo-build
May 28, 2019
Merged

Fix monorepo build#115
Marc-Andre-Rivet merged 2 commits into
masterfrom
fix-monorepo-build

Conversation

@Marc-Andre-Rivet

Copy link
Copy Markdown
Contributor

No description provided.

@Marc-Andre-Rivet
Marc-Andre-Rivet marked this pull request as ready for review May 28, 2019 13:12
Comment thread .circleci/config.yml Outdated
command: |
git clone git@github.com:plotly/dash.git
git clone git@github.com:plotly/dash-renderer.git
git clone git@github.com:plotly/dash.git dash-main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shallow clone can save a lot of time, no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, will search and replace for table/html/core

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 shallow clone would be nice but is non-blocking - we should do that consistently anyway, not just where things changed.

@Marc-Andre-Rivet
Marc-Andre-Rivet merged commit b3e1ac6 into master May 28, 2019
@Marc-Andre-Rivet
Marc-Andre-Rivet deleted the fix-monorepo-build branch May 28, 2019 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants