Breaking potential loops, allowing widgets to be used to both get and set slicer position#45
Merged
Conversation
Collaborator
Author
|
@surchs if this fixes it for you and does not break anything, then this should be good to go. The PR looks larger than it is, because it's mostly splitting a callback in two. |
Contributor
|
I'm trying it out right now, will let you know once it's running! |
Contributor
|
Hey @almarklein, this looks good to me. Works in my example (to both show in and change from an input field the slicer position). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44