Boolean values not showing

[moi90]

Like in the experimental version, cells with boolean values are empty, regardless of True or False.

plotly/dash-table-experiments#10

[Marc-Andre-Rivet]

Notes for implementation:

This is caused by react's inability to handle boolean values inside of jsx(tsx).

See current usage: https://github.com/plotly/dash-table/blob/master/src/dash-table/components/CellLabel/index.tsx#L27

By changing line 27 for something like:

            {typeof value === 'boolean' ?
                value.toString() :
                value
            }

we should be able to display the boolean under a string format.

Additionally, adding support for PropTypes.bool in the dropdown props seems to work as-is with the current dropdown implementation and should be folded in with the explicit toString fix.

One of the dropdown props: https://github.com/plotly/dash-table/blob/master/src/dash-table/dash/DataTable.js#L686

That said, the table does not currently have native boolean type support and the resolution of this issue would not add that support.

Greatest uncertainty is how this is going to be handled by filtering and sorting.

Add some tests for label / input (focused) / dropdown (focused) + updating as text or from dropdown + check behavior of various filter ops & sort.

[Marc-Andre-Rivet]

@moi90 Thanks for reporting this issue.

[moi90]

@Marc-Andre-Rivet Thanks for working on this issue!

So far, I convert Boolean values before displaying them.